[mythtv-commits] mythtv commits

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Sun Feb 6 18:15:02 EST 2005

Changes committed by cpinkham on Sun Feb  6 23:14:54 2005

Modified Files:
   in mythtv/libs/libmythtv:
        dbcheck.cpp programinfo.cpp programinfo.h 
   in mythtv/programs/mythbackend:
   in mythtv/programs/mythfrontend:
        playbackbox.cpp playbackbox.h 
Log Message:

This looks bigger than it is.  I'm putting a big description in the
commit log so people can see what changes are being made since this
issue has been discussed a bit over the past few days on the -dev list.

* Couple more changes related to the recent delete thread change.
  These changes implement most of the changes that have been talked
  about in the thread "Recent BUG: deleting from Watch Recordings"
  on the -dev list.  I believe the only part missing would be an
  external thread to handle deletes.  This patch makes the Watch
  Recordings screen act as it did prior to the recent delete thread
  changes related to metadata deletion.  When a user deletes a
  recording, the recording list should reload automatically and the
  deleted recording should not be visible anymore.  If there is a
  problem deleting the file by the backend, the recording will
  reappear on the Watch Recordings screen.

  List of changes are:
  - Create a 'deletepending' flag in the recorded table.  This field
    is set to 0 by default for a recording and to 1 when the backend
    receives a delete command from the frontend.
  - Modify MainServer::HandleQueryRecordings() to only retrieve
    shows with a deletepending value of 0.  This makes the frontend
    only see programs which are NOT marked for deletion.
  - Modify ProgramInfo::GetProgramFromRecorded() to retrieve the
    recordid with the rest of the program info.
  - Modify MainServer::DoDeleteThread to load the program info for
    the recording being deleted.  This allows DoDeleteThread() to
    set the deletepending flag back to 0 if there is an error
    deleting the file for a recording.
  - The call to ScheduledRecording::signalChange which was moved
    from playbackbox.cpp to MainServer::DoDeleteThread originally
    was passed an argument of 0.  Based on information from Bruce
    Markey, the method needs to be called with the recordid of
    the program being deleted in order for the scheduler to properly
    take into account whether the user selected "Allow re-record"
    when the program was deleted.
  - Remove the pendingDeletes QStringlist that was being used for
    the old temporary way of setting the recording to display in
    the "inactive" font to give the user feedback that the delete
    was taking effect.


More information about the mythtv-commits mailing list