[mythtv-commits] Ticket #755: add handling of current/next program EIT information

[MythTV]

#755: add handling of current/next program EIT information
----------------------------------------+-----------------------------------
 Reporter:  mythdev at penyball.cix.co.uk  |       Owner:  danielk
     Type:  enhancement                 |      Status:  new    
 Priority:  minor                       |   Milestone:  0.19   
Component:  mythtv                      |     Version:  head   
 Severity:  low                         |  
----------------------------------------+-----------------------------------
 UK freeview uses the 4E/4F pid's for current/next program details. The
 current EIT scan ignores these - however they often seem to include last
 minute schedule changes. The patch below is all that seems to be needed to
 use them on dvb-t
 (only tested against ttusb-dec and bt8xx)
 {{{
 Index: mythtv/libs/libmythtv/siparser.cpp
 ===================================================================
 --- mythtv/libs/libmythtv/siparser.cpp  (revision 8106)
 +++ mythtv/libs/libmythtv/siparser.cpp  (working copy)
 @@ -573,6 +573,7 @@
              ParseSDT(&head, &buffer[8], size-8);
              break;
  #ifdef USING_DVB_EIT
 +        case 0x4E ... 0x4F:
          case 0x50 ... 0x6F:
              /* Standard Future Event Information Table(s) */
              ParseDVBEIT(&head, &buffer[8], size-8);
 @@ -1293,7 +1294,8 @@

      // TODO: This is temp
      Table[EVENTS]->DependencyMet(SERVICES);
 -    Table[EVENTS]->AddPid(0x12,0x00,0x00,true);
 +    Table[EVENTS]->AddPid(0x12,0x7F,0x80,true);
 +
  }

  /** \fn GetLanguagePriority(const QString&)
 }}}

 In looking at this I guessed that either the AddPid has been assumed to be
 against DVB/SIParser or there has been a change in the definition of
 TableHandler::AddPid that means the last changed line above seems to be
 logicaly incorrect, or I've misread the overrides! :) - the prototypes at
 svn 8106 are
 {{{
 EventHandler
 void AddPid(uint16_t pid,uint8_t filter, uint8_t mask, uint8_t key);
 TableHandler
 virtual void AddPid(uint16_t pid,uint8_t filter, uint8_t mask, uint8_t key
 = 0)
 }}}
 where key is used as an index into a QMap of added pid's
 It doesn't affect the current functionality but to help any later
 maintenance should the last line of the change be something like:
 {{{
 +    Table[EVENTS]->AddPid(0x12,0x7F,0x80,0x12);
 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/755>
MythTV <http://www.mythtv.org/>
MythTV