[mythtv-commits] Ticket #260: Patch to centralize categories/colors
MythTV
mythtv at cvs.mythtv.org
Wed Aug 24 21:06:16 UTC 2005
#260: Patch to centralize categories/colors
--------------------------------------------------------+-------------------
Reporter: Marcelo Toledo <marcelo at marcelotoledo.org> | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone:
Component: mythtv | Version: head
Severity: medium | Cc: |
--------------------------------------------------------+-------------------
= The problem =
Today the EPG colorization is done by inserting lines in the ui.xml file
available in a theme (i.e. G.A.N.T. or blue). The problem is that for each
theme you must copy each entry twice in diferent regions of the xml. If
one day we have 10 themes we will have 20 copies of the same
lines, which is really bad for maintainance, today we have 5 ui.xml's to
maintain (2 in mythtv and 3 in myththemes).
= The solution =
All category/color entries in ui.xml were synced and moved to the file
mythtv/themes/categories.xml which is parsed by a new function called
'parseDefaultCategoryColors' (mythtv/libs/libmyth/xmlparse.cpp), this way
the categories are stored in only one file (mythtv/themes/categories.txt),
which is much better for maintainence. Also a particular theme may
override a default category/color in it's ui.xml.
Attached goes 2 patches:
== epg-categories.patch ==
* themes/G.A.N.T./ui.xml and themes/blue/ui.xml had the same entries so
it was all moved to categories.xml.
* Creates themes/categories.xml
* Added support to install/uninstall categories.xml in themes/themes.pro
* Declares the function 'parseDefaultCategoryColors' in
libs/libmyth/xmlparse.h
* Defines the function 'parseDefaultCategoryColors' in
libs/libmyth/xmlparse.cpp, calls the new function before ui.xml is loaded.
== remove-catcolor.patch ==
* Modified Titivillus/ui.xml, Iulius/ui.xml and Minimalist-wide/ui.xml to
contain only distincted categories/colors.
* NOTE: this patch is for myththemes component.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/260>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list