[mythtv-commits] Ticket #250: Patch to centralize categories/colors
MythTV
mythtv at cvs.mythtv.org
Mon Aug 22 17:47:09 UTC 2005
#250: Patch to centralize categories/colors
--------------------------------------------------------+-------------------
Reporter: Marcelo Toledo <marcelo at marcelotoledo.org> | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone:
Component: mythtv | Version: head
Severity: medium | Cc: |
--------------------------------------------------------+-------------------
= The problem =
Today the EPG colorization is done by inserting lines in the ui.xml file
available in a theme (i.e. G.A.N.T. or blue). The problem is that for each
theme you must copy each entry twice in diferent regions of the xml. If
one day we have 10 themes we will have 20 copies of the same lines, which
is really bad for maintainance, today we have 5 ui.xml's to maintain (2 in
mythtv and 3 in myththemes).
= The solution =
All category/color entries in ui.xml were moved to the file
mythtv/themes/categories.xml which is parsed by a new function called
'parseCategoryColors' (mythtv/libs/libmyth/xmlparse.cpp), this way the
categories are stored in only one file (mythtv/themes/categories.txt),
which is much better for maintainence.
Attached goes 2 patches:
== epg-categories.patch ==
* Removes all catcolor entries in themes/G.A.N.T./ui.xml and
themes/blue/ui.xml
* Creates themes/categories.xml with merged content from all ui.xml
* Added support to install/uninstall categories.xml in themes/themes.pro
* Declares the function 'parseCategoryColors' in libs/libmyth/xmlparse.h
* Defines the function 'parseCategoryColors' in
libs/libmyth/xmlparse.cpp, removes the code that was used to parse
catcolor entries in the function 'parseGuideGrid', instead calls the new
function
== remove-catcolor.patch ==
* Removes all catcolor entries in tTitivillus/ui.xml, Iulius/ui.xml and
Minimalist-wide/ui.xml
* NOTE: this patch is for myththemes component.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/250>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list